Test cases failing to compile in ROMS 3.7

[AlexisEspinosa]

Test case riverplume2 fails to compile in ROMS V3.7 (build 737),
and I guess that many other test cases may be in the same situation as this 'first' case I have tried after upgrading to ROMS 3.7 has a lot of typing mistakes!!

Please, can you perform a check of all the test cases in the ROMS repository?

In the meantime, here is the solution to make riverplume2 to compile:

The file ana_psource.h needs to be corrected for a typographical errors in
------------------------------------------------------
in line 264:
change
& z_w(i,j ,N(ng))-
into the correct
& z_w(i,j ,N(ng))- &

------------------------------------------------------
in line 271:
change
SOURCES(ng0%Qshape(Nsrc(ng),k)=1.0_r8/REAL(N(ng),r8)
into the correct
SOURCES(ng)%Qshape(Nsrc(ng),k)=1.0_r8/REAL(N(ng),r8)

-----------------------------------------------------
in line 277:
change
SOURCES(ng)%Qshape=RESHAPE(Pwrk,(/Msrc,N(ng)/))
into the correct
SOURCES(ng)%Qshape=RESHAPE(Pwrk,(/Msrc(ng),N(ng)/))

-----------------------------------------------------
in line 341:
change
CALL mp_collect (ng, iNLM, Msrc, Pspv, SOURCES(ng)%Qbar)
into the correct
CALL mp_collect (ng, iNLM, Msrc(ng), Pspv, SOURCES(ng)%Qbar)

Cheers,
Alexis Espinosa-Gayosso
UWA

[AlexisEspinosa]

The modifications above were neccesary for the compilation,
But after running the case it was not giving the right results:
Basically nothing was happening, i.e. there was no plume at all!

Comparing against ROMS 3.6 (build 670) two important lines were missing
again in the ana_psource.h file:

in the section for RIVERPLUME2 in line 456:
add the two missing lines in order to have the correct:
# elif defined RIVERPLUME2
IF (DOMAIN(ng)%NorthEast_Test(tile)) THEN
DO k=1,N(ng)
DO is=1,Nsrc(ng)
SOURCES(ng)%Tsrc(is,k,itemp)=T0(ng)
SOURCES(ng)%Tsrc(is,k,isalt)=S0(ng)
END DO
SOURCES(ng)%Tsrc(Nsrc,k,itemp)=T0(ng)
SOURCES(ng)%Tsrc(Nsrc,k,isalt)=0.0_r8
END DO
END IF
# else

Now you can identify the fresh water plume!!

Cheers,
Alexis Espinosa-Gayosso
UWA

[arango]

Indeed, thank you for reporting this.