Typos in roms.in and varinfo.dat

[stlaur]

A few typos in the trunk version. In file User/External/roms.in:

Code: Select all

! Input lateral boundary conditions and climatology file names.  The
! USER has the option to split input data time records into several
! NetCDF files (see prologue instructions above). If so, use a single
! line per entry with a vertical bar (|) symbol after each entry,
! except the last one.

     BRYNAME == roms_bry.nc
     CLMNAME == roms_clm.nc

! Input climatology nudging coefficients file name.

This block is missing the parameters NBCFILES and NCLMFILES.

In file ROMS/External/varinfo.dat:

Code: Select all

'river_PON'                                        ! Input
  'river runoff particulate organic nitrogen'
  'millimole_nitrogen meter-3'                     ! [millimole/m3]
  'river_DON, scalar, series'
  'river_time'
  'idRtrc(iDON_)'
  'nulvar'
  1.0d0

The 4th line should be 'river_PON, scalar, series'. The 6th line should be 'idRtrc(iPON_)'.

Code: Select all

'PO4'                                              ! Input/Output
  'phosphate concentration'
  'millimole_PO4 meter-3'                          ! [millimole/m3]
  'PO4, scalar, series'
  'ocean_time'
  'idTvar(iPO4_)'
  'r3dvar'
  1.0d0

This entry appears twice in the file (with the exact same spelling).
The duplicate entry can be found with a search on 'idTvar(iPO4_)'.

Code: Select all

'RDeN_west'                                        ! Input
  'river carbon detritus western boundary condition'
  'millimole_carbon meter-3'                       ! [millimole/m3]
  'RDeC_west, scalar, series'
  'RDeC_time'
  'idTbry(iwest,iRDeC)'
  'nulvar'
  1.0d0

'RDeN_north'                                       ! Input
  'river carbon detritus northern boundary condition'
  'millimole_carbon meter-3'                       ! [millimole/m3]
  'RDeC_north, scalar, series'
  'RDeC_time'
  'idTbry(inorth,iRDeC)'
  'nulvar'
  1.0d0

'RDeN_south'                                       ! Input
  'river carbon detritus southern boundary condition'
  'millimole_carbon meter-3'                       ! [millimole/m3]
  'RDeC_south, scalar, series'
  'RDeC_time'
  'idTbry(isouth,iRDeC)'
  'nulvar'
  1.0d0

The first line of these 3 entries should be 'RDeC_west', 'RDeC_north', and 'RDeC_south', respectively.

[arango]

Yes, I did notice those, thank you! As a matter of fact, I replaced varinfo.dat with a YAML file varinfo.yaml. It will released with ROMS 4.1. Stay tuned.

[pmaccc]

I think a couple of other river variables required by the Fennel code may also be missing from varinfo.dat. In fennel_var.h (release 1054) it asks for:
CASE ('idRtrc(iPhyt)')
idRtrc(iPhyt)=varid
CASE ('idRtrc(iZoop)')
idRtrc(iZoop)=varid

but there are no phytoplankton or zooplankton river fields in varinfo.dat.