possible bug in set_tides.F

[stef]

I'm trying to do harmonic analysis and detiding, and get weird results for a child grid when nesting. The results for the parent grid seem ok.

Searching for a possible bug in ROMS, I noticed in set_tides.F

Code: Select all

!
! If nested grids and detiding, load period and harmonics to other
! grids.
!
      IF (LprocessTides(ng)) THEN
        DO mg=1,Ngrids
          IF (ng.ne.mg) THEN
            DO itide=1,NTC(ng)
              TIDES(mg)%Tperiod (1:NTC(ng))=TIDES(ng)%Tperiod (1:(ng))
              TIDES(mg)%SinOmega(1:NTC(ng))=TIDES(ng)%SinOmega(1:(ng))
              TIDES(mg)%CosOmega(1:NTC(ng))=TIDES(ng)%SinOmega(1:(ng))
            END DO
          END IF
        END DO
      END IF

Note the line with ...CosOmega... = ...SinOmega...

I have not yet tried if this fixes my problem, but I guess it's at least a typo.

Thanks!

[arango]

Yes, that's definitely a typo. Thank you for bringing that to our attention. Luckily, this logic is only used to detide ROMS fields (AVERAGES_DETIDE) via the least-squares fit of time-averaged fields.