Search found 8 matches

by harcourt
Sun Oct 13, 2024 1:53 pm
Forum: ROMS Source
Topic: GLS & MY25 Advection and Constraints. Posted from PECS2024
Replies: 1
Views: 2358

Re: GLS & MY25 Advection and Constraints. Posted from PECS2024

Sorry, but those two prestep routines have errors in the new code changes still. In each of the prestep routines there is a pair of lines, one for each horizontal direction of third-order upstream advection, that says: IF (cff.gt.0.0_r8) THEN The first of these should read IF (XF(i,j).gt.0.0_r8 ...
by harcourt
Thu Sep 26, 2024 8:00 am
Forum: ROMS Discussion
Topic: Noise of vertical mixing using GLS turbulence closure model
Replies: 18
Views: 3904

Re: Noise of vertical mixing using GLS turbulence closure model

There is a problem with the advection schemes for turbulence if you are not specifying one of the 2 centered schemes, which may be contributing to the noise you are dealing with. Please see my modified code posted for GLS and MY25 here: https://www.myroms.org/forum/viewtopic.php?p=25663#p25663 I ...
by harcourt
Thu Sep 26, 2024 7:56 am
Forum: ROMS Source
Topic: GLS & MY25 Advection and Constraints. Posted from PECS2024
Replies: 1
Views: 2358

GLS & MY25 Advection and Constraints. Posted from PECS2024

Attached are revisions of 4 code modules for the predictor and corrector steps of GLS and MY25 second moment closure options. They correct an incongruity in the default cpp selection of predictor and corrector advection schemes, one that seems to go back at least 2 decades to version 2.0 per ...
by harcourt
Tue Mar 14, 2023 6:54 pm
Forum: ROMS Bugs
Topic: Possible Coding Error in gls_corstep.F: application of gls_Kmin and gls_Pmin to control advection
Replies: 4
Views: 22905

Possible Coding Error in gls_corstep.F: application of gls_Kmin and gls_Pmin to control advection

Not 100% sure, but I think there is a coding error in the application of gls_Kmin and gls_Pmin to limit values produced by horizontal and vertical advection of tke and gls for models using any of the GLS-wrapped versions of second moment closure (and hence entering ROMS/Nonlinear/gls_prestep.F ...
by harcourt
Thu Dec 20, 2018 7:54 pm
Forum: ROMS Bugs
Topic: Equation error in GLS model coded into gls_corstep.F
Replies: 5
Views: 4222

Re: Equation error in GLS model coded into gls_corstep.F

I had some exchange with Hans Burchard on this with CC to John Warner -- ought to have cc'd you too, Hernan. I summarize that exchange here: Burchard: Around 2005, we had a major update in the turbulence routines coordinated by Lars, and I cannot find any pre-2005 GOTM code where we use the limiting ...
by harcourt
Fri Dec 14, 2018 7:43 pm
Forum: ROMS Bugs
Topic: Equation error in GLS model coded into gls_corstep.F
Replies: 5
Views: 4222

Re: Equation error in GLS model coded into gls_corstep.F

Here is a Matlab program (with apologies to open-source folk) to demonstrate the problem with the published & ROMS-coded equation for the smoothed Gh limiter, based on 3 different closure options that invoke it in ROMS within gls_corstep.F . High resolution of Gh is needed to see the problem in ...
by harcourt
Thu Dec 13, 2018 9:32 pm
Forum: ROMS Bugs
Topic: Equation error in GLS model coded into gls_corstep.F
Replies: 5
Views: 4222

Equation error in GLS model coded into gls_corstep.F

Hi. I've been working on putting different turbulence closures into the COAWST version of ROMS and into GOTM, and I think I have found a longstanding problem in the published account of an aspect of the GLS turbulence closure model, and in the resulting implementation in ROMS. The problem involves a ...
by harcourt
Wed Mar 16, 2016 11:06 pm
Forum: ROMS Source
Topic: Turbulent momentum flux down Stokes gradient
Replies: 0
Views: 17696

Turbulent momentum flux down Stokes gradient

I've been working on putting in a MY2.5-variant parameterization of Langmuir turbulence (Harcourt,2013; 2015; + newer mods) that entails a component of the vertical momentum flux directed down the gradient of the surface waves' Stokes drift, i.e.: <u'w'> = - K_M du/dz - K_W du^s/dz where u is ...